Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet: default to source-built sdk/runtimes #363008

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

dotnet: default to source-built sdk/runtimes #363008

wants to merge 4 commits into from
+104 −70

Conversation

corngood
Copy link
Contributor

@corngood corngood commented Dec 8, 2024

This makes source-built packages the default (when available) for dotnet-{sdk,runtime,aspnetcore}, as well as in dotnetCorePackages.

Binary packages are available explicitly with a -bin suffix.

One potential breaking change is that SDKs will point to the newest available source-built version. For example, dotnet-sdk_8 now points to the source build of 8.0.1xx, where it previously would have been the latest binary SDK: 8.0.4xx.

We could choose not to do this, and prefer the latest version regardless of source provenance. If we backport this we should maintain the versions being used in the release branch.

Cc: @NixOS/dotnet

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GGG-KILLER
Copy link
Contributor

GGG-KILLER commented Dec 8, 2024 •
edited
Loading

I think we should prefer the latest version whenever possible for dotnet-{sdk,runtime,aspnetcore}, even if there aren't changes to the runtime, we can still end up benefiting from some patches that improve performance or similar things.

Given that from .NET 9 onwards they should have source builds for every X.Y.Z00 version, we should be able to keep the source-build for a while.

Since the runtime doesn't have those release channels, maybe we can use the source-build for them and then use the binary one for the SDK?

@corngood
Copy link
Contributor Author

corngood commented Dec 8, 2024

Since the runtime doesn't have those release channels, maybe we can use the source-build for them and then use the binary one for the SDK?

That's what will happen for dotnet-runtime. We could potentially go a step further and overwrite the embedded runtime in the SDK packages. Maybe even symlink it sort of like combinePackages.

That would allow us to dependably patch the runtime.

@GGG-KILLER
Copy link
Contributor

Well, if we can guarantee that the source-built runtime and binary runtime are fully compatible and a drop-in replacement, I'd say no reason not to do it.

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: dotnet Language: .NET 6.topic: games 6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corngood @GGG-KILLER